C++ string coredump解决思路
C++ string coredump
请高手帮忙看一下为啥调用几百万次之后可能会在packetData里面产生coredump，backtrace也在后面附上了，请高手指导下
源代码：
调用处：
while(ptr != NULL){
//printf("grane11,jsonData,ptr:%s,machineIP:%s\n" , ptr,machineIP.c_str());
string jsonData = packetData(ptr,machineIP);
// printf("grane1100,after jsonData:%s\n" ,jsonData.c_str());
pthread_mutex_lock(&mut_redis);
strQu.push(jsonData);
pthread_cond_signal(&cond_redis);
pthread_mutex_unlock(&mut_redis);
ptr = strtok_r(NULL, "\n", &pSave);
line ++;
}
函数实现：
inline string CDataStore::packetData(char *line,string& IP)
{
gettimeofday(&tv,NULL);
long timeRcv = tv.tv_sec;
char mytime[11] ={'\0'};
snprintf(mytime,sizeof(mytime),"%d",(int)timeRcv);
string time = mytime;
string jsonfile = "";
jsonfile += "\{\"IP\":\"";
jsonfile += IP;
jsonfile += "\",\"data\":\"";
jsonfile += line;
jsonfile += "\",\"time\":\"";
jsonfile += time;
jsonfile += "\"";
jsonfile += "}\n";
return jsonfile;
/*
Json::FastWriter writer;
Json::Value redisData;
redisData["IP"] = IP;//grane todo IP
redisData["time"] = time;
redisData["data"] = line;
string json_file = writer.write(redisData);
return json_file;
*/
}
coredump的backtrace：
#0 0x0000003219030285 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003219030285 in raise () from /lib64/libc.so.6
#1 0x0000003219031d30 in abort () from /lib64/libc.so.6
#2 0x000000321906971b in __libc_message () from /lib64/libc.so.6
#3 0x00000032190711df in _int_free () from /lib64/libc.so.6
#4 0x000000321907163b in free () from /lib64/libc.so.6
#5 0x000000321a89cb9e in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::reserve(unsigned long) () from /usr/lib64/libstdc++.so.6
#6 0x000000321a89cd5f in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(char const*, unsigned long) () from /usr/lib64/libstdc++.so.6
#7 0x0000000000409c48 in CDataStore::packetData (line=0x2aaaad36c81f "\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)", IP=
"111.111.111.111") at DataStore.cpp:456
#8 0x0000000000406cbb in CDataStore::getLineThreadFun (arg=0x7fff661bea48) at DataStore.cpp:362
#9 0x0000003219c0677d in start_thread () from /lib64/libpthread.so.0
#10 0x00000032190d3c1d in clone () from /lib64/libc.so.6
------解决思路----------------------
在多线程环境下频繁new delete那是作死的节奏啊！
搜“线程池“、“内存池“、“连接池”
参考下面程序管理跨线程内存和消息的思路：
请高手帮忙看一下为啥调用几百万次之后可能会在packetData里面产生coredump，backtrace也在后面附上了，请高手指导下
源代码：
调用处：
while(ptr != NULL){
//printf("grane11,jsonData,ptr:%s,machineIP:%s\n" , ptr,machineIP.c_str());
string jsonData = packetData(ptr,machineIP);
// printf("grane1100,after jsonData:%s\n" ,jsonData.c_str());
pthread_mutex_lock(&mut_redis);
strQu.push(jsonData);
pthread_cond_signal(&cond_redis);
pthread_mutex_unlock(&mut_redis);
ptr = strtok_r(NULL, "\n", &pSave);
line ++;
}
函数实现：
inline string CDataStore::packetData(char *line,string& IP)
{
gettimeofday(&tv,NULL);
long timeRcv = tv.tv_sec;
char mytime[11] ={'\0'};
snprintf(mytime,sizeof(mytime),"%d",(int)timeRcv);
string time = mytime;
string jsonfile = "";
jsonfile += "\{\"IP\":\"";
jsonfile += IP;
jsonfile += "\",\"data\":\"";
jsonfile += line;
jsonfile += "\",\"time\":\"";
jsonfile += time;
jsonfile += "\"";
jsonfile += "}\n";
return jsonfile;
/*
Json::FastWriter writer;
Json::Value redisData;
redisData["IP"] = IP;//grane todo IP
redisData["time"] = time;
redisData["data"] = line;
string json_file = writer.write(redisData);
return json_file;
*/
}
coredump的backtrace：
#0 0x0000003219030285 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x0000003219030285 in raise () from /lib64/libc.so.6
#1 0x0000003219031d30 in abort () from /lib64/libc.so.6
#2 0x000000321906971b in __libc_message () from /lib64/libc.so.6
#3 0x00000032190711df in _int_free () from /lib64/libc.so.6
#4 0x000000321907163b in free () from /lib64/libc.so.6
#5 0x000000321a89cb9e in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::reserve(unsigned long) () from /usr/lib64/libstdc++.so.6
#6 0x000000321a89cd5f in std::basic_string<char, std::char_traits<char>, std::allocator<char> >::append(char const*, unsigned long) () from /usr/lib64/libstdc++.so.6
#7 0x0000000000409c48 in CDataStore::packetData (line=0x2aaaad36c81f "\tat org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)", IP=
"111.111.111.111") at DataStore.cpp:456
#8 0x0000000000406cbb in CDataStore::getLineThreadFun (arg=0x7fff661bea48) at DataStore.cpp:362
#9 0x0000003219c0677d in start_thread () from /lib64/libpthread.so.0
#10 0x00000032190d3c1d in clone () from /lib64/libc.so.6
------解决思路----------------------
在多线程环境下频繁new delete那是作死的节奏啊！
搜“线程池“、“内存池“、“连接池”
参考下面程序管理跨线程内存和消息的思路：
//循环向a函数每次发送200个字节长度（这个是固定的）的buffer,
//a函数中需要将循环传进来的buffer，组成240字节（也是固定的）的新buffer进行处理，
//在处理的时候每次从新buffer中取两个字节打印
#ifdef WIN32
#pragma warning(disable:4996)
#endif
#include <stdio.h>
#include <stdlib.h>
#include <string.h>
#ifdef WIN32
#include <windows.h>
#include <process.h>
#include <io.h>
#define MYVOID void
#define vsnprintf _vsnprintf
#else
#include <unistd.h>
#include <sys/time.h>
#include <pthread.h>
#define CRITICAL_SECTION pthread_mutex_t
#define MYVOID void *
#endif
//Log{
#define MAXLOGSIZE 20000000
#define MAXLINSIZE 16000
#include <time.h>
#include <sys/timeb.h>
#include <stdarg.h>
char logfilename1[]="MyLog1.log";
char logfilename2[]="MyLog2.log";
static char logstr[MAXLINSIZE+1];
char datestr[16];
char timestr[16];
char mss[4];
CRITICAL_SECTION cs_log;
FILE *flog;
#ifdef WIN32
void Lock(CRITICAL_SECTION *l) {
EnterCriticalSection(l);
}
void Unlock(CRITICAL_SECTION *l) {
LeaveCriticalSection(l);
}
void sleep_ms(int ms) {
Sleep(ms);
}
#else
void Lock(CRITICAL_SECTION *l) {
pthread_mutex_lock(l);
}
void Unlock(CRITICAL_SECTION *l) {
pthread_mutex_unlock(l);
}
void sleep_ms(int ms) {
usleep(ms*1000);
}
#endif
void LogV(const char *pszFmt,va_list argp) {
struct tm *now;
struct timeb tb;
if (NULL==pszFmt
------解决思路----------------------
0==pszFmt[0]) return;
vsnprintf(logstr,MAXLINSIZE,pszFmt,argp);
ftime(&tb);
now=localtime(&tb.time);
sprintf(datestr,"%04d-%02d-%02d",now->tm_year+1900,now->tm_mon+1,now->tm_mday);
sprintf(timestr,"%02d:%02d:%02d",now->tm_hour ,now->tm_min ,now->tm_sec );
sprintf(mss,"%03d",tb.millitm);
printf("%s %s.%s %s",datestr,timestr,mss,logstr);
flog=fopen(logfilename1,"a");
if (NULL!=flog) {
fprintf(flog,"%s %s.%s %s",datestr,timestr,mss,logstr);
if (ftell(flog)>MAXLOGSIZE) {
fclose(flog);
if (rename(logfilename1,logfilename2)) {
remove(logfilename2);
rename(logfilename1,logfilename2);
}
} else {
fclose(flog);
}
}
}
void Log(const char *pszFmt,...) {
va_list argp;
Lock(&cs_log);
va_start(argp,pszFmt);
LogV(pszFmt,argp);
va_end(argp);
Unlock(&cs_log);
}
//Log}
#define ASIZE 200
#define BSIZE 240
#define CSIZE 2
char Abuf[ASIZE];
char Cbuf[CSIZE];
CRITICAL_SECTION cs_HEX ;
CRITICAL_SECTION cs_BBB ;
struct FIFO_BUFFER {
int head;
int tail;
int size;
char data[BSIZE];
} BBB;
int No_Loop=0;
void HexDump(int cn,char *buf,int len) {
int i,j,k;
char binstr[80];
Lock(&cs_HEX);
for (i=0;i<len;i++) {
if (0==(i%16)) {
sprintf(binstr,"%03d %04x -",cn,i);
sprintf(binstr,"%s %02x",binstr,(unsigned char)buf[i]);
} else if (15==(i%16)) {
sprintf(binstr,"%s %02x",binstr,(unsigned char)buf[i]);
sprintf(binstr,"%s ",binstr);
for (j=i-15;j<=i;j++) {
sprintf(binstr,"%s%c",binstr,('!'<buf[j]&&buf[j]<='~')?buf[j]:'.');
}
Log("%s\n",binstr);
} else {
sprintf(binstr,"%s %02x",binstr,(unsigned char)buf[i]);
}
}
if (0!=(i%16)) {
k=16-(i%16);
for (j=0;j<k;j++) {
sprintf(binstr,"%s ",binstr);
}
sprintf(binstr,"%s ",binstr);
k=16-k;
for (j=i-k;j<i;j++) {
sprintf(binstr,"%s%c",binstr,('!'<buf[j]&&buf[j]<='~')?buf[j]:'.');
}
Log("%s\n",binstr);
}
Unlock(&cs_HEX);
}
int GetFromRBuf(int cn,CRITICAL_SECTION *cs,FIFO_BUFFER *fbuf,char *buf,int len) {
int lent,len1,len2;
lent=0;
Lock(cs);
if (fbuf->size>=len) {
lent=len;
if (fbuf->head+lent>BSIZE) {
len1=BSIZE-fbuf->head;
memcpy(buf ,fbuf->data+fbuf->head,len1);
len2=lent-len1;
memcpy(buf+len1,fbuf->data ,len2);
fbuf->head=len2;
} else {
memcpy(buf ,fbuf->data+fbuf->head,lent);
fbuf->head+=lent;
}
fbuf->size-=lent;
}
Unlock(cs);
return lent;
}
MYVOID thdB(void *pcn) {
char *recv_buf;
int recv_nbytes;
int cn;
int wc;
int pb;
cn=(int)pcn;
Log("%03d thdB thread begin...\n",cn);
while (1) {
sleep_ms(10);
recv_buf=(char *)Cbuf;
recv_nbytes=CSIZE;
wc=0;
while (1) {
pb=GetFromRBuf(cn,&cs_BBB,&BBB,recv_buf,recv_nbytes);
if (pb) {
Log("%03d recv %d bytes\n",cn,pb);
HexDump(cn,recv_buf,pb);
sleep_ms(1);
} else {
sleep_ms(1000);
}
if (No_Loop) break;//
wc++;
if (wc>3600) Log("%03d %d==wc>3600!\n",cn,wc);
}
if (No_Loop) break;//
}
#ifndef WIN32
pthread_exit(NULL);
#endif
}
int PutToRBuf(int cn,CRITICAL_SECTION *cs,FIFO_BUFFER *fbuf,char *buf,int len) {
int lent,len1,len2;
Lock(cs);
lent=len;
if (fbuf->size+lent>BSIZE) {
lent=BSIZE-fbuf->size;
}
if (fbuf->tail+lent>BSIZE) {
len1=BSIZE-fbuf->tail;
memcpy(fbuf->data+fbuf->tail,buf ,len1);
len2=lent-len1;
memcpy(fbuf->data ,buf+len1,len2);
fbuf->tail=len2;
} else {
memcpy(fbuf->data+fbuf->tail,buf ,lent);
fbuf->tail+=lent;
}
fbuf->size+=lent;
Unlock(cs);
return lent;
}
MYVOID thdA(void *pcn) {
char *send_buf;
int send_nbytes;
int cn;
int wc;
int a;
int pa;
cn=(int)pcn;
Log("%03d thdA thread begin...\n",cn);
a=0;
while (1) {
sleep_ms(100);
memset(Abuf,a,ASIZE);
a=(a+1)%256;
if (16==a) {No_Loop=1;break;}//去掉这句可以让程序一直循环直到按Ctrl+C或Ctrl+Break或当前目录下存在文件No_Loop
send_buf=(char *)Abuf;
send_nbytes=ASIZE;
Log("%03d sending %d bytes\n",cn,send_nbytes);
HexDump(cn,send_buf,send_nbytes);
wc=0;
while (1) {
pa=PutToRBuf(cn,&cs_BBB,&BBB,send_buf,send_nbytes);
Log("%03d sent %d bytes\n",cn,pa);
HexDump(cn,send_buf,pa);
send_buf+=pa;
send_nbytes-=pa;
if (send_nbytes<=0) break;//
sleep_ms(1000);
if (No_Loop) break;//
wc++;
if (wc>3600) Log("%03d %d==wc>3600!\n",cn,wc);
}
if (No_Loop) break;//
}
#ifndef WIN32
pthread_exit(NULL);
#endif
}
int main() {
#ifdef WIN32
InitializeCriticalSection(&cs_log);
InitializeCriticalSection(&cs_HEX );
InitializeCriticalSection(&cs_BBB );
#else
pthread_t threads[2];
int threadsN;
int rc;
pthread_mutex_init(&cs_log,NULL);
pthread_mutex_init(&cs_HEX,NULL);
pthread_mutex_init(&cs_BBB,NULL);
#endif
Log("Start===========================================================\n");
BBB.head=0;
BBB.tail=0;
BBB.size=0;
#ifdef WIN32
_beginthread((void(__cdecl *)(void *))thdA,0,(void *)1);
_beginthread((void(__cdecl *)(void *))thdB,0,(void *)2);
#else
threadsN=0;
rc=pthread_create(&(threads[threadsN++]),NULL,thdA,(void *)1);if (rc) Log("%d=pthread_create %d error!\n",rc,threadsN-1);
rc=pthread_create(&(threads[threadsN++]),NULL,thdB,(void *)2);if (rc) Log("%d=pthread_create %d error!\n",rc,threadsN-1);
#endif
if (!access("No_Loop",0)) {
remove("No_Loop");
if (!access("No_Loop",0)) {
No_Loop=1;
}
}
while (1) {
sleep_ms(1000);
if (No_Loop) break;//
if (!access("No_Loop",0)) {
No_Loop=1;
}
}
sleep_ms(3000);
Log("End=============================================================\n");
#ifdef WIN32
DeleteCriticalSection(&cs_BBB );
DeleteCriticalSection(&cs_HEX );
DeleteCriticalSection(&cs_log);
#else
pthread_mutex_destroy(&cs_BBB);
pthread_mutex_destroy(&cs_HEX);
pthread_mutex_destroy(&cs_log);
#endif
return 0;
}